[✔] Restoring avatar only loads part of the items

[Akuyi]

I stumbled upon another issue with the avatar creator: It often only loads part of the items, both upon initial load and on clicking the "restore" button.

It generally always loads items that I didn't touch between the last two saves, and doesn't load most of the items that I did change.

How to reproduce:
I used these two sets of items, but it probably works with any.

* Save avatar with black hair and blue eyes
* Go to the edit avatar screen. If both eyes and hair are displaying correctly, do the following:
** change the hair to brown and then right back to black
** change the eyes to brown
** save
* Go to the edit avatar screen again. It will fail to load the hair or eyes.

I sometimes do get different results (missing hair, missing eyes, nothing missing), depending on the order in which I do these steps and the row the item is in (or maybe it depends on the actual item, I'm not sure).

Observed on Firefox 49.0.2.

[Diana]

Sometimes the avatar gets a little funny, I think it's because of connection timeout when saving items to the db. I'll keep poking at it when I get the chance.

You say what happens is different when you equip items in different orders though?

[Akuyi]

Yeah I feel like sometimes one of the items I change vanishes and sometimes the other. I'm not sure if there's some underlying rule behind it though.

[Akuyi]

I just tested this with a new account on another browser. Bought some shirts and pants from the shop.

I equipped the following items in that order:
⬛ shirt
⬛ pants > none showed up on reload

equipped both again > showed up on reload

⬛ shirt
⬛ pants > both showed up

⬛ shirt
⬛ pants > none showed up

again > both showed up

⬛ shirt
⬛ pants > none showed up

again > both showed up

⬛ pants
⬛ shirt > both showed up

⬛ pants
⬛ shirt > only shirt shows up

again > both show up

⬛ pants
⬛ shirt > both show up

⬛ pants
⬛ shirt > none show up

⬛ shirt
⬛ pants > both show up

Tried to toggle back and forth the color:
⬛⬛ shirt
⬛⬛ pants > only pants show up

added shirt again

⬛⬛ shirt
⬛⬛ pants > only shirt shows up


... all in all, it looks kinda random to me. If I do the very same things in the very same order again, I get different results, too.

[Diana]

Okay, it seemed random to me too. Thanks for taking such a detailed look into that!
I will continue to poke at it when I get the chance.