[Fixed] Confirming a Cancelled Trade

[Akuyi]

Okay, this was a bit weird, and I don't know whether it's supposed to behave like that.

I sent a trade to azzy. Then I got two pms:

Trade Update

You are being notified because the status of one of your trades with azzy has changed.

Trade Cancelled

You are being notified because your trad with azzy has been cancelled.

Apart from the spelling mistake... Apparently azzy thought they could only cancel the trade because nothing happened when they accepted. Now the funny thing is, I followed the link to the supposedly cancelled trade and was able to confirm it. And it's listed as a completed trade in my history now.



Azzy doesn't seem to have received the items though.

[Diana]

Whoop! Ill look into it, thanks for the report!

[Akuyi]

No prob. c:

[Lemon Cheesecake]

did azzy accept the second trade attempt? After the first one was cancelled? From the few I have done they don't automatically show in your inventory the person receiving has to accept the trade.

[Akuyi]

Well, as far as I'm aware there's only three states a trade can have (if it doesn't get cancelled):
1) Person A sent the trade. At this stage person A can still do changes to their side.
2) Person B accepted the trade. At this point person B can still do changes to their side.
3) Person A confirmed. At this point the trade is complete.

Correct me if I am wrong.

Now what happened was that azzy finished (2) but didn't wait for my confirmation and instead cancelled the trade and then I did (3) even though the trade was cancelled. If I am not mistaken there should be no way for azzy to accept a trade after stage (3) because at that point the trade is supposed to be complete.

[Diana]

Okay, so I ran through what happened real quick. Looks like Azzy accepted the trade, Akuyi loaded the trade to confirm it (which has a different URL, maybe used the link from a PM?), and then Azzy rejected the trade before Akuyi confirmed.

When the trade was cancelled, all the items attached to it were returned to their original orders, so the only thing that happened on the confirm was the final status changed.

I fixed the typo in the PM, and am adding some extra checks for the status of the trade, so that should stop happening.

[Akuyi]

Oh okay, that somehow makes sense.
Thanks!